Re: [6/6]: jenkins hash for neigh
From: "David S. Miller" <davem@davemloft.net>
Date: 2004-09-27 18:15:20
On Mon, 27 Sep 2004 21:48:33 +1000 Herbert Xu [off-list ref] wrote:
quoted
- if (tbl->entries > (tbl->hash_mask + 1)) + if (tbl->entries > (tbl->hash_mask + 1)) { + write_lock_bh(&tbl->lock); neigh_hash_grow(tbl, (tbl->hash_mask + 1) << 1); + write_unlock_bh(&tbl->lock); + }The locking should be outside the if block as otherwise you may grow unnecessarily or grow into the same size :)
I'm not going to do that, because then we're grabbing that lock twice on every neigh create operation and I was trying hard to avoid that overhead.