Re: bad TSO performance in 2.6.9-rc2-BK
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2004-09-27 05:45:41
On Sun, Sep 26, 2004 at 09:00:29PM -0700, David S. Miller wrote:
The very next time we check to see if we can make forward progress on the send queue we'll call tcp_current_mss() which causes the right things to happen.
tcp_current_mss() doesn't call tcp_sync_mss() unless the PMTU changes.
Something else is wrong. I think part of it is that we need to make tcp_clean_rtx_queue() return FLAG_DATA_ACKED even when a partial TSO packet is ACK'd by the other end. This will make RTO etc. calculations actually occur, among other things. But I have no idea if that will clear up the performance problems TSO is having with the new code.
There probably is something else wrong, since this should only limit the TSO size. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt