Re: [IPv4]: More fib_alias insertion fixes
From: Julian Anastasov <ja@ssi.bg>
Date: 2004-09-26 06:15:58
From: Julian Anastasov <ja@ssi.bg>
Date: 2004-09-26 06:15:58
Hello, On Sat, 25 Sep 2004, David S. Miller wrote:
2) The fib_alias list is not meant at all to be sorted by TOS value. Within a TOS it _is_ sorted by priority. This was intentional, and I believe your changes assume I meant to keep the "aliases ordered by TOS" property. I did not.
But it still needs one exception: the entries with TOS 0 must be at tail to allow fn_hash_lookup to match by TOS. With random TOS insertion this is not guaranteed, the entries with TOS=0 (wildcard) will match before the others. So, I fixed it to allow the TOS subchains to be in any order but always before the subchain with TOS 0.
Please give test cases when posting fixes of this nature. I wouldn't have to guess about #2 if you gave a bunch of "ip route foo" commands that gave behavior you think is incorrect.
ok, I'm attaching 3 files: new diff, test script to add/del entries in custom table and its output in another file (after applying the patch). I'm using: ./rt.sh start ./rt.sh stop Regards -- Julian Anastasov [off-list ref]