On Sat, Sep 04, 2004 at 10:11:46AM -0400, jamal wrote:

On Sat, 2004-09-04 at 09:28, Andi Kleen wrote:

quoted

On Wed, Sep 01, 2004 at 10:33:01PM -0700, David S. Miller wrote:

quoted

On Tue, 31 Aug 2004 14:38:20 +0200
Andi Kleen [off-list ref] wrote:

quoted

This patch extends the recently added NETIF_F_LLTX to real devices.

Well, it does a lot of other things too.

Not really, it all works to the same goal.

Must be my sleep depravation - what is LLTX again?

NETIF_F_LLTX - a new flag that tells the stack the the driver
doesn't want an xmit lock. 

quoted

quoted

least the user would find out in their logs.  With your
change the system explodes looping with no explanation why.

Hmm, I guess if you're really worried about this class
of driver bugs ble eing common adding some real error handling
for it (like bailing out and disabling the device) would
be the far better option.

Actually that message is pretty useful.
I have seen at least a handful of badly written drivers do that.

They will still print that, no problem. 

quoted

quoted

patch 1) Change macros into inlines
patch 2) local_bh_disable() preemption count optimization
patch 3) support for F_LLTX on real devices
patch 4) locking changes

At least (3) and (4) are the same thing. I can drop the 
inlines, it was only for making the code clearer and less ugly
but is not essential for the optimizations.

do you guys mind if i test these patches/patch out first before final 
inclusion? Next weekend i will have the chance.

You can do that, but they won't do much unless your driver sets
NETIF_F_LLTX. 

-Andi