Re: [PATCH] SLAB_PANIC cleanup

Em Tue, Aug 17, 2004 at 03:59:42PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ escreveu:

In article [ref] (at Tue, 17 Aug 2004 02:43:38 -0400 (EDT)), James Morris [off-list ref] says:

It generally seems okay. Just a few things for readability.

quoted

diff -urN -X dontdiff linux-2.6.8.1-mm1.o/net/core/neighbour.c linux-2.6.8.1-mm1.w/net/core/neighbour.c

--- linux-2.6.8.1-mm1.o/net/core/neighbour.c	2004-06-16 01:18:56.000000000 -0400
+++ linux-2.6.8.1-mm1.w/net/core/neighbour.c	2004-08-17 02:57:22.888296160 -0400

@@ -1165,12 +1165,9 @@
 	if (!tbl->kmem_cachep)
 		tbl->kmem_cachep = kmem_cache_create(tbl->id,
 						     tbl->entry_size,
-						     0, SLAB_HWCACHE_ALIGN,
+						     0, SLAB_HWCACHE_ALIGN|
+						     SLAB_PANIC,

I rather prefer
						     tbl->entry_size, 0,
						     SLAB_HWCACHE_ALIGN|SLAB_PANIC,

I rather prefer:

                                                     SLAB_HWCACHE_ALIGN | SLAB_PANIC,

Regards,

- Arnaldo