Re: [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware

On Thu, Jul 22, 2004 at 10:27:32AM +0200, Margit Schubert-While wrote:

2004-07-22 Margit Schubert-While [off-list ref]

* In the card initialization routine, we try to set the
  output power. For firmware < 1.0.4.3, this leads to a
  worrying "mgt_commit has failed .." in the log although
  the device continues to react normally.
  Fix is simple, do not try to configure output power.
  (which I believe we should not be doing anyway as it is 
   probably against local country regulations)

Margit

Margit, I think we should rather detect the version of the firmware and
depending on this decide what to do.

A quick test proves you can obtain firmware verion from

[OID_INL_VERSION] = {0xFF020005, 0, 8, OID_TYPE_RAW},

Then somewhere,

union oid_res_t r;
char *ver;

mgt_get_request(priv, OID_INL_VERSION, 0, NULL, &r);
ver = (char *) r.ptr;
printk(KERN_DEBUG "Version: %s\n", ver);

This will either be 1.0.4.3.arm or 1.0.3.0.arm. You can then strcmp and
do the right thing. I'd finish this work up but I'm busy with WPA.

	Luis

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E