Re: 2.6.7 error message (oops)

On Tuesday 22 June 2004 12:47, Herbert Xu wrote:

Bernd Schubert [off-list ref] wrote:

quoted

I just booted 2.6.7 on one of our systems and see this oops from dmesg:

eth11: network connection down
Debug: sleeping function called from invalid context at
include/asm/semaphore.h:119
in_atomic():0, irqs_disabled():1
[<c01072ae>] dump_stack+0x1e/0x20
[<c0121690>] __might_sleep+0xb0/0xe0
[<c0433ecb>] netdev_run_todo+0x2b/0x290
[<c04338e9>] dev_ioctl+0x269/0x300
[<c0476e0c>] inet_ioctl+0x8c/0xa0
[<c04292c8>] sock_ioctl+0x138/0x350
[<c017e2b4>] sys_ioctl+0x144/0x2d0
[<c01063bf>] syscall_call+0x7/0xb

The device eth11 is the (ifrename) mapped eth1:

sk98lin: Network Device Driver v6.23

OK the locking in this driver needs to be reviewed and simplified.

In this case it's doing two spin_lock_irqsave() calls in a row on the
same flags variable.

Does this patch fix your problem?

Thanks a lot, your patch fixed this problem! Though I had to apply it 
manually, since patch somehow didn't like it. Maybe it got broken when you 
sent the mail?

Attached is the re-diffed patch (looks completely identical to me, but diff 
says the whitespace is different):


Thanks,
	Bernd