Thread (8 messages) 8 messages, 2 authors, 2004-06-26

[IPSEC] Remove run-time encap_type checks in esp4

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2004-06-26 01:57:15

On Fri, Jun 25, 2004 at 10:39:28AM -0700, David S. Miller wrote:
On Fri, 25 Jun 2004 22:35:27 +1000
Herbert Xu [off-list ref] wrote:
quoted
Here is the patch to check encap_type at the earliest possible
opportunity in xfrm_user/af_key.
Applied.
Thanks.

This allows us to remove all the per-packet checks on x->encap->encap_type.
I've left the check in esp_input just in case someone adds a non-ESP encap
type in future.

However, printing a warning and then continuing is definitely wrong.
So expect a follow-up patch to drop the packet when encap_type is
unknown in esp_input.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help