Re: MSEC_TO_JIFFIES is messed up...

On Wed, 12 May 2004 Valdis.Kletnieks@vt.edu wrote:

On Wed, 12 May 2004 21:33:49 +0200, Ingo Molnar said:

quoted

* Jeff Garzik [off-list ref] wrote:

quoted

quoted

Woah, that's new.  And wrong.  The code in include/asm-i386/param.h that
says:
# define JIFFIES_TO_MSEC(x)     (x)
# define MSEC_TO_JIFFIES(x)     (x)

Is not correct.  Look at kernel/sched.c for verification of this :)

Yes, that is _massively_ broken.

why is it wrong?

If the kernel jiffie is anything other than exactly 1 msec, you're screwed... 

I believe they were talking about include/asm-i386/param.h
                                          ^^^^^^^^


- Davide