Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h

On Tue, Mar 16, 2004 at 11:34:56AM -0800, Linus Torvalds wrote:

On Tue, 16 Mar 2004, Russell King wrote:

quoted

quoted

What are your thoughts on this?

So how do we solve this problem.  Should I just merge this change and
ask you to pull it?  I think that's rather impolite though.

I didn't apply the patch because you said it was untested ;)

Ok, but bear in mind that although I can test that removing linux/irq.h
from netpoll.h fixes my problem, it really needs an x86 person to also
test it, just in case there's some dependency there that may not show
up for me.

I'll happily remove that irq.h include if it really doesn't do anything 
but break things. I'd feel happier about it if somebody said it has been 
tested, though ;)

Andi Kleen, hch and jgarzik are presently discussing the issue, and I
think they're convincing themselves that linux/irq.h is disgusting
mess.

As far as me doing anything with linux/irq.h, I think that's out of my
control because ARM doesn't use it - an x86 person needs to look into
fixing it properly.

So all I can do is moan each time this problem comes up until someone
gets pissed off enough to fix it properly.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core