Re: Problem with dev_kfree_skb_any() in 2.6.0
From: David S. Miller <hidden>
Date: 2004-01-01 20:48:04
Also in:
lkml
From: David S. Miller <hidden>
Date: 2004-01-01 20:48:04
Also in:
lkml
On Tue, 30 Dec 2003 12:43:21 -0500 Jeff Garzik [off-list ref] wrote:
Luckily, I feel there is an easy solution, as shown in the attached patch. We _already_ queue skbs in dev_kfree_skb_irq(). Therefore, dev_kfree_skb_any() can simply use precisely that same solution. The raise-softirq code will immediately proceed to action if we are not in hard IRQ context, otherwise it will follow the expected path.
Ok, this is reasonable and works. Though, is there any particular reason you don't like adding a "|| irqs_disabled()" check to the if statement instead? I prefer that solution better actually.