Joseph Fannin wrote:

"Craig A. Huegen" [off-list ref] wrote:

quoted

In the same vein as:
http://seclists.org/lists/linux-kernel/2003/Oct/5794.html

quoted

...there is a bug in the SiS900 driver in 2.6.1 which prevents multicast
MAC filtering from working properly.  This breaks IPv6.

    I'm seeing this problem too.  My sis900 interface can't get an
IPv6 address unless promiscious or allmulti mode is set, since it
doesn't get responses on ip6-allrouters.

    Please note that I am not subscribed to netdev, so a CC on any
responses would be appreciated.

quoted

Patch attached (same one as from the 2.4 post from Oct 28) that made
IPv6 work for me again.

    From the original post, referring to the change this reverts:

quoted

quoted

This will not work for bit_nr larger than 16 and hence the failure.
Reverting to use set_bit causes multicast to be handled properly.

quoted

--- linux/drivers/net/sis900.c.old	2004-01-17 03:56:53.893211412 -0600
+++ linux/drivers/net/sis900.c	2004-01-17 03:57:02.785567615 -0600

@@ -2091,9 +2091,8 @@

		rx_mode = RFAAB;
		for (i = 0, mclist = net_dev->mc_list; mclist && i < net_dev->mc_count;
		     i++, mclist = mclist->next) {
-			unsigned int bit_nr =
-				sis900_mcast_bitnr(mclist->dmi_addr, revision);
-			mc_filter[bit_nr >> 4] |= (1 << bit_nr);
+			set_bit(sis900_mcast_bitnr(mclist->dmi_addr, revision),
+				mc_filter);
		}
	}

    This fix didn't go into 2.4 either, so presumably something is wrong
with it (perhaps we're moving away from set_bit)?  I am over my head
here really, but I don't want to just set allmulti mode and forget
about this bug.

Correct, set_bit should only occur on unsigned long variables.  So, the 
code needs to manually set that bit.

	Jeff