David S. Miller wrote:

On Mon, 15 Dec 2003 14:46:59 -0800
Ben Greear [off-list ref] wrote:

quoted

Maybe the stats-polling code in the driver could do the necessary subtraction
to remove the FCS from the results (ie, subtract (packets-since-last-sample * 4) bytes.

The whole reason to use the chip internally computed stats is to avoid
having to do "stats->foo++" at all, your suggestion basically eliminates
this purpose.

Well, I was assuming that the stats polling is a fixed cost O(1), where-as the per-packet
calculation is O(n).  I am quite sure this assumption is true for e1000,
but I have not looked at tg3.  So, for e1000, the cost of subtracting out the FCS
would be basically free.

All that said, from Randy's email, it appears we should be including the FCS
anyway...

Ben

-- 
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com