Thread (5 messages) 5 messages, 4 authors, 2003-11-30

Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy

From: Ingo Oeser <hidden>
Date: 2003-11-30 10:57:01
Also in: lkml

Possibly related (same subject, not in this thread)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 28 November 2003 10:42, David Woodhouse wrote:
On Thu, 2003-11-27 at 23:09 +0100, Felipe Alfaro Solana wrote:
quoted
On Thu, 2003-11-27 at 21:48, Timo Kamph wrote:
quoted
quoted
+	strlcpy(label->label, name, sizeof(label->name));
                                                                      
^^^^^^ I guess this shoud be label->label, or am I wrong?
Oh my god! Two consecutive mistakes with the same patch! I should have
some sleep... Here's the one with the typo corrected.
Perhaps we should consider

#define strsizecpy(x, y) strlcpy((x), (y), sizeof(x))
Then we should do:

#define strsizecpy(x, y) strlcpy(x, y, sizeof(x)/sizeof(x[0]))

to rule out passing the wrong variables or dereferencing to much.

Unfortunatly there is no simple way in C to differentiate between array and
pointer.

There is a way with typeof, but that is hackish.


Regards

Ingo Oeser

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/ycXOU56oYWuOrkARAiJ8AJ9wkl1ijJVn5M+lGhUwSwWRxzxxHwCg2nAU
t+9HdAasQDZo/GQFuj9s5ZU=
=py/4
-----END PGP SIGNATURE-----
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help