hw checksum acceleration (Was: problem in driver network code)

On Mon, Nov 10, 2003 at 09:14:17AM +0100, francois donzet wrote:

quoted

What do you do with an IEEE 802.1q (VLAN) or 802.2
(LLC) packet? The VLAN
code in vlan_skb_recv() does not adjust skb->csum or
skb->ip_summed. Neither
does the 802.2 code.

no matter the link layer header is 802.3,802.2 or
8021.q . Tcp checksum offloading is supported,
whatever the type of the link layer (as skb->csum is
computed without the link layer header).

The documentation says that skb->csum covers the whole packet as seen by
netif_rx(). eth_type_trans() pulls off the 14 byte header before netif_rx()
is called. But if the frame is really 802.1q or 802.2, then the extra bytes
of the header will be pulled off but skb->csum will still cover those bytes.
Unless, of course, the device knows about 802.1q and 802.2, but that wasn't
supposed to be necessary, was it?

-- 
Regards,
Rask Ingemann Lambertsen