Thread (1 message) 1 message, 1 author, 2003-10-18

Re: [PATCH] Prevent "eth0: driver changed get_stats after register" lying

From: Russell King <hidden>
Date: 2003-10-18 20:47:49

On Sat, Oct 18, 2003 at 09:46:22PM +0100, Russell King wrote:
There appears to be a race condition between netdev_register_sysfs
and hotplug.  I'm seeing the message in the subject upon initialisation
of pcnet_cs.

We set "dev->last_stats" after we have registered the class device.
During class device registration, we trigger the hotplug scripts,
which can in turn bring up the interface.  This in turn checks to
see if "dev->last_stats == dev->get_stats", and, since we haven't
set dev->last_stats yet, we complain.
Incidentally, this also means that hotplug scripts can run before
we've registered the class device attributes.  Could that be another
problem?  It's probably something that the hotplug people should
be aware of.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help