Thread (7 messages) 7 messages, 2 authors, 2004-01-15

Re: [PATCH]Implementation for IPv6 MIB:ipv6InterfaceTable

From: David S. Miller <hidden>
Date: 2003-10-14 22:24:41

On Tue, 14 Oct 2003 10:32:23 -0700
Shirley Ma [off-list ref] wrote:
+#ifdef CONFIG_SYSCTL
+#include <linux/sysctl.h>
+#endif
Please don't add ifdefs around header includes like this if
you can avoid it.
+void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
 ...
+extern int ndisc_ifinfo_sysctl_change(ctl_table *ctl, int write, struct file 
 ...
+extern void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
 ...

These belong in header files, not scattered around in *.c files.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help