Re: [PATCH] (1/5) get rid of useless hashbin in irtty
From: Jean Tourrilhes <hidden>
Date: 2003-08-17 01:36:24
On Sat, Aug 16, 2003 at 06:09:46PM -0700, David S. Miller wrote:
On Sat, 16 Aug 2003 18:11:31 -0700 Jean Tourrilhes [off-list ref] wrote:quoted
Would it be possible for Stephen to use some real IrDA hardware so that he can double check what he is doing ?And alternatively, what? We let known bugs sit in the tree because of IRDA?
Wow ! I did not mean to argue and stop the work, if you understood that, I'm sorry for the misunderstanding. I'm just trying to understand the reason for it, how best to proceed, and that's why I took the time to give Stephen some constructive suggestions (as well as my worries). I'm just doing my job, and I don't think I'm unnegociable.
We've had to edit and hack on lots of obscure ISA ethernet drivers to do this so far that probably nobody has tried to use in years and very few people have access to. Not just trivial changes, we've had to rewrite some of their probe routines in some cases.
It's fairly easy to get hold of some IrDA hardware, and in the worse case you can use a serial crossover cable to test it. It's not like I'm asking the impossible.
The work simply must be done.
After your explanation, I didn't argue with that. But let's do quality work, not a quick job.
If we add bugs, the first person who tries to use it will find out and report the problem.
If the bug report come in one year, nobody will remember the context of the work. It's better to get it right the first time, and that's what I'm trying to acheive. Have fun... Jean