Thread (9 messages) flat view 9 messages, 5 authors, 2003-08-13

Re: RFR: new SiS gige driver

From: Stephen Hemminger <hidden>
Date: 2003-08-08 19:01:50

Comments:
	- Run through lindent, indenting is non-standard.

	- struct board_info defined but only used in one debug message
	  and it is just a string.

	- C99 initializers?

	- if code is commented out and outdated remove it (see init_board)

	- poisoning memory is useless and done already by allocator
	  (see SIS190_remove_one)

	- assert checks for null pointers are overkill

	- ethtool?

Overall, suffers a little from the "having more debug code makes my
driver more reliable" fallacy.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help