Thread (5 messages) 5 messages, 5 authors, 2003-06-05

Re: 2.5.70-bk+ broken networking

flat view

From: Stephen Hemminger <hidden>
Date: 2003-06-05 16:42:08
Also in: lkml

On Thu, 5 Jun 2003 13:25:58 +1000 (EST)
James Morris [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Wed, 4 Jun 2003, Patrick Mansfield wrote:
quoted
[root@elm3b79 root]# ifup eth0
sender address length == 0
This is a bug introduced by a coding style cleanup, fix below.


- James
-- 
James Morris
[off-list ref]
--- bk.pending/net/core/iovec.c	2003-06-05 11:12:59.000000000 +1000
+++ bk.w1/net/core/iovec.c	2003-06-05 13:30:06.000000000 +1000
@@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
 						  address);
 			if (err < 0)
 				return err;
-			m->msg_name = address;
-		} else
-			m->msg_name = NULL;
-	}
+		}
+		m->msg_name = address;
+	} else
+		m->msg_name = NULL;
 
 	size = m->msg_iovlen * sizeof(struct iovec);
 	if (copy_from_user(iov, m->msg_iov, size))
Thanks, this works for me.  I will see if it fixes the other gnome mystery as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help