Re: 2.5.70-bk+ broken networking

On Wed, Jun 04, 2003 at 04:25:31PM -0700, Andrew Morton wrote:

Stephen Hemminger wrote:

quoted

Test machine running 2.5.70-bk latest can't boot because eth2 won't
come up.  The same machine and configuration successfully brings up
all the devices and runs on 2.5.70.

kjournald is stuck waiting for IO to complete against some buffer
during transaction commit.

I'd be suspecting block layer or device drivers.  What device driver
is handling your /var/log?

I also can't get networking up on current bk, I don't know if this is
the same problem, the system did not hang (I'm not running NIS?).

I also got that "sender address length == 0" message, I have not seen it
before, it seems to be output by the "ip -o link".

During boot:

[ ... ]
Enabling local filesystem quotas:  [  OK  ]
Enabling swap space:  [  OK  ]
/bin/cat: /proc/ksyms: No such file or directory
INIT: Entering runlevel: 3
Entering non-interactive startup
Setting network parameters:  [  OK  ]
Bringing up interface lo:  [  OK  ] 
sender address length == 0 
sender address length == 0
Starting system logger: [  OK  ]
Starting kernel logger: [  OK  ]
Starting portmapper: [  OK  ]  
Starting NFS file locking services:
[ ... ]

After logging in:

[root@elm3b79 root]# ifup eth0
sender address length == 0
[root@elm3b79 root]# ip -o link
sender address length == 0
[root@elm3b79 root]# dmesg | grep eth0
eth0: Digital DS21140 Tulip rev 33 at 0xf8800000, 00:00:BC:0F:03:EB, IRQ 36.

-- Patrick Mansfield

On Wed, 4 Jun 2003, Patrick Mansfield wrote:

[root@elm3b79 root]# ifup eth0
sender address length == 0

This is a bug introduced by a coding style cleanup, fix below.


- James
-- 
James Morris
[off-list ref]

--- bk.pending/net/core/iovec.c	2003-06-05 11:12:59.000000000 +1000
+++ bk.w1/net/core/iovec.c	2003-06-05 13:30:06.000000000 +1000

@@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
 						  address);
 			if (err < 0)
 				return err;
-			m->msg_name = address;
-		} else
-			m->msg_name = NULL;
-	}
+		}
+		m->msg_name = address;
+	} else
+		m->msg_name = NULL;
 
 	size = m->msg_iovlen * sizeof(struct iovec);
 	if (copy_from_user(iov, m->msg_iov, size))

For the curious, it was introduced in changeset 1.1259.9.18

- Arnaldo

Em Thu, Jun 05, 2003 at 01:25:58PM +1000, James Morris escreveu:

   From: Arnaldo Carvalho de Melo [off-list ref]
   Date: Thu, 5 Jun 2003 00:32:08 -0300

   For the curious, it was introduced in changeset 1.1259.9.18
   
Christophe, PLEASE be more careful in the future.

I value your changes, very much.  However, you really need to get a
little more meticulious when you submit changes.

Thanks.

On Thu, 5 Jun 2003 13:25:58 +1000 (EST)
James Morris [off-list ref] wrote:

Thanks, this works for me.  I will see if it fixes the other gnome mystery as well.