On Wed, 2003-05-21 at 16:27, David S. Miller wrote:

   From: Arnaldo Carvalho de Melo [off-list ref]
   Date: Wed, 21 May 2003 20:18:01 -0300
   
   Already submitted to DaveM, CCed netdev, I'll fix this later
   tonight.

Note that, as I said in another email, these MOD_* calls can't just be
deleted, the PROCFS registry etc. have to set ->owner fields correctly
before this is valid.

By just removing MOD_*(), I can load just wanrouter, open a proc file,
unload the wanrouter module, and crash.

The proc file looked like a separate problem.  The MOD_* calls I removed
were in register_wan_device/unregister_wan_device, so these did not
protect the procfs entries for wanrouter.  If another module called
register_wan_device, the wanrouter module couldn't be unloaded because
of the symbol reference.  Of course, the modules that call
register_wan_device also need to kept from being unloaded until
have unregister_wan_device.  Again, I thought these were separate
problems.

Arnaldo, sorry about the conflicting patch.  We in the middle of moving
and I hadn't had a chance to catch up on the mailing list.

-- 
Daniel McNeil [off-list ref]