Re: comment about struct tcp_tw_bucket in struct sock
From: Arnaldo Carvalho de Melo <hidden>
Date: 2003-05-22 00:52:58
From: Arnaldo Carvalho de Melo <hidden>
Date: 2003-05-22 00:52:58
Em Wed, May 14, 2003 at 09:21:17PM +0200, Andi Kleen escreveu:
On Wed, May 14, 2003 at 12:18:06PM -0700, David S. Miller wrote:quoted
From: Andi Kleen [off-list ref] Date: Wed, 14 May 2003 10:32:36 +0200 On Tue, May 13, 2003 at 04:31:50PM -0700, David S. Miller wrote: > It's documented in tcp.h already. Just not everybody changing sock.h also reads tcp.h :-( You assume that protocols in the tree are the only thing that might break if you edit struct sock.I'm not assuming anything and didn't even edit struct sock, just pointing out that such a fragile hack as the current tw bucket is needs an explicit comment on both places. Best would be to bite the bullet and give them a common structure.
Ah if we could just use a unnamed struct... 8) - Arnaldo