[PATCH] Re: Another holiday, another set of tg3 releases.

On Sun, Jan 12, 2003 at 01:14:03AM +0100, Jean-Daniel Pauget wrote:

on 2002-12-30, Jeff Garzik [off-list ref] wrote :

quoted

Another holiday, another set of tg3 releases.

    in my seek for unexpected freeze of my box (not yet figured which
    hardware is involved exactly) I updated to tg3-1.2a and applied
    both tg3-1.2a-00_irqsave and tg3-1.2a-01_mask_rewrite.
    as a result, after working a few seconds the network card freezes, and
    no ifupdown would permit any recovery.

    on the other hand, with only the first patch tg3-1.2a-00_irqsave, things
    seems ok and I'm waiting for my machine to freeze... ...or not. (the freeze
    frequency is ~10hours )...

Thanks, please do keep us posted.

I have attached two patches, with accompanying descriptions, that I have
been testing locally on UP and SMP.  They are a bit more conservative
than tg3-1.2a-01_mask_rewrite while still addressing the same issue.

Right now my plan for tg3 version 1.3 (next release) is:
	tg3-1.2a-00_irqsave
	tg3-irq-mask-2.patch (attached), and
	tg3-irq-flush.patch (attached)
	and maybe the MTU stuff [more on that below]

The first patch, 00_irqsave, is a bit too paranoid for DaveM's liking,
so even though I will to apply 00_irqsave, that area will get further
attention once existing bug reports are resolved.

[Note to DaveM -- tg3_timer is not a fast path, so extra paranoia there
won't hurt]

    though, on your page you mention a fifth patch concerning mtu, as I'm
    running with an unusual mtu of 1452 because of internet over internet
    encapsulation on my DSL, maybe I'm concerned ?

MTU of 1452 should not be a problem.  The issue is more of correcting
handling of change-MTU condition that rarely happens.

	Jeff