Hi David,

here is an updated version with the following changes:

-split the patch: First adds the userspace notification, the other
(depends on the first) RFC2863 semantics. I am aware that we are well
beyond feature freeze, and it makes the code more readable.
-simplified locking as suggested
-made the notification unconditional. We want it ;-)
-fixed a bug in RFC2863 netif_carrier_ok() emulation (was !=, should be
==)

Can you have a look?

Stefan


"David S. Miller" wrote:

This locking below achieves nothing.

+       read_lock_irqsave(&dev->operstate_lock, flags);
+       state = dev->operstate;
+       read_unlock_irqrestore(&dev->operstate_lock, flags);

In fact, the other side, locking when setting this value, can
be done with a simple spinlock.  Probably something else in
the device struct can be reused.

I also don't think this should be conditional, either we want
it or we don't.