Thread (20 messages) 20 messages, 4 authors, 2002-08-14

Re: raw ipv6 broken in 2.4.19

flat view

From: Julian Anastasov <ja@ssi.bg>
Date: 2002-08-14 00:15:09

	Hello,

On 13 Aug 2002, Martin Josefsson wrote:
On Tue, 2002-08-13 at 15:58, kuznet@ms2.inr.ac.ru wrote:
quoted
Very strange. We have similar phenomenon reported with TCP, by the way.
So, I have to assume that checksumming routine is wrong and does some shit
sort of relying on an uninitialized data.
I've added some debug printk's and found out that it's the call to
csum_fold that fails in skb_copy_and_csum_datagram_iovec.
	What about the known problem with csum_partial called
with zero length. IIRC, on CONFIG_X86_USE_PPRO_CHECKSUM compilation
this function depends on the data alignment (addr&2!=0 => bug) - calling 
csum_partial with zero length in 2.4+ is a bug, checks should be added
in the caller. Can this be problem with skb_copy_and_csum_datagram_iovec? 
I see that net/ipv6/raw.c provides 0 as hlen.

Regards

--
Julian Anastasov [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help