Thread (1 message) 1 message, 1 author, 2002-05-21

Re: System crash in tcp_fragment()

From: <hidden>
Date: 2002-05-21 01:00:11

Hello!
Such rule does not even make this piece of code legal.  Consider:

task1:cpu0:	x = counters[smp_processor_id()];
      cpu0:	PREEMPT
task2:cpu0:	x = counters[smp_processor_id()];
task2:cpu0:	counters[smp_processor_id()] = x + 1;
      cpu0:	PREEMPT
task1:cpu0:	counters[smp_processor_id()] = x + 1;
		full garbage
Yup. And this has nothing to do with SMP...

But it does bring up important point, preemption people need to
fully audit entire networking.
Well, we can make this. It is too serious. Anyway, this means that
preemptive patch for 2.4 is "tainting" :-)

Alexey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help