Re: [LTP] [PATCH] sparse: Skip TCID and TST_TOTAL
From: Richard Palethorpe <hidden>
Date: 2021-11-30 14:06:53
Hello, Cyril Hrubis [off-list ref] writes:
quoted hunk ↗ jump to hunk
Since these are part of the old library API. Signed-off-by: Cyril Hrubis <chrubis@suse.cz> --- tools/sparse/sparse-ltp.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/tools/sparse/sparse-ltp.c b/tools/sparse/sparse-ltp.c index b1677d336..1a3b4089a 100644 --- a/tools/sparse/sparse-ltp.c +++ b/tools/sparse/sparse-ltp.c@@ -98,6 +98,9 @@ static void check_symbol_visibility(const struct symbol *const sym) if (!(mod & MOD_TOPLEVEL)) return; + if (!strcmp(name, "TCID") || !strcmp(name, "TST_TOTAL")) + return;
Would it be better to print a warning that old library crap has been detected? My expectation is that 'make check' will produce a lot of noise if ran on tests which haven't even been converted to the new library. Also it's possible someone may forget to remove TCID etc.
+
if (has_lib_prefix && (mod & MOD_STATIC) && !(mod & MOD_INLINE)) {
warning(sym->pos,
"LTP-003: Symbol '%s' has the LTP public library prefix, but is static (private).",
--
2.32.0-- Thank you, Richard. -- Mailing list info: https://lists.linux.it/listinfo/ltp