Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable

Hi Christophe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc2 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-randconfig-a015-20211121 (attached as .config)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0f65744094ce515a9dfe6b5e655ad59861eca35b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
        git checkout 0f65744094ce515a9dfe6b5e655ad59861eca35b
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:1438:11: error: called object type 'int' is not a function or function pointer

                                                GFP_KERNEL);
                                                ^
   include/linux/gfp.h:324:20: note: expanded from macro 'GFP_KERNEL'
   #define GFP_KERNEL      (__GFP_RECLAIM | __GFP_IO | __GFP_FS)
                           ^
   1 error generated.


vim +/int +1438 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c

  1426	
  1427	static int init_doorbell_bitmap(struct qcm_process_device *qpd,
  1428				struct kfd_dev *dev)
  1429	{
  1430		unsigned int i;
  1431		int range_start = dev->shared_resources.non_cp_doorbells_start;
  1432		int range_end = dev->shared_resources.non_cp_doorbells_end;
  1433	
  1434		if (!KFD_IS_SOC15(dev->device_info->asic_family))
  1435			return 0;
  1436	
  1437		qpd->doorbell_bitmap = bitmap_zalloc(KFD_MAX_NUM_OF_QUEUES_PER_PROCESS

1438						     GFP_KERNEL);

  1439		if (!qpd->doorbell_bitmap)
  1440			return -ENOMEM;
  1441	
  1442		/* Mask out doorbells reserved for SDMA, IH, and VCN on SOC15. */
  1443		pr_debug("reserved doorbell 0x%03x - 0x%03x\n", range_start, range_end);
  1444		pr_debug("reserved doorbell 0x%03x - 0x%03x\n",
  1445				range_start + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
  1446				range_end + KFD_QUEUE_DOORBELL_MIRROR_OFFSET);
  1447	
  1448		for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
  1449			if (i >= range_start && i <= range_end) {
  1450				set_bit(i, qpd->doorbell_bitmap);
  1451				set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
  1452					qpd->doorbell_bitmap);
  1453			}
  1454		}
  1455	
  1456		return 0;
  1457	}
  1458	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org