Re: [PATCH] compiler_types: mark __compiletime_assert failure as __noreturn

From
Nick Desaulniers <ndesaulniers@google.com>
Date
2021-10-14 18:55:46
Also in
lkml
Reply to
Miguel Ojeda, 2021-10-14
On Thu, Oct 14, 2021 at 11:41 AM Miguel Ojeda
[off-list ref] wrote:
On Thu, Oct 14, 2021 at 8:33 PM Miguel Ojeda
[off-list ref] wrote:
quoted
That would be a nice to do, but I am not sure about introducing one
more macro about this... I think it would be simpler to submit patches
for moves into `static_assert` even if we have to "flip" the meaning.
$ grep -r BUILD_BUG_ON | wc -l
3405
Actually, what would be ideal is a compiler-backed lint that checks
whether it could be an `static_assert`, perhaps in clang-tidy?
Oh, that is a good idea.  There is one already for recommending the
use of static_assert instead of assert.  That's actually very nice.

I was playing with trying to adapt clang-tidy's C++11 `auto` fixit to
work on GNU C code to automate the replacement of:

__typeof(x) y = (x);

with:

__auto_type y = (x);

in macros.  That's perhaps interesting, too.  Given the volume of code
in the kernel, I wouldn't waste time with one off patches; rather I'd
work on automation (since clang-tidy can be taught "fixits" to fix the
code in place, not just warn) so that we can better enable treewide
changes AND keep new instances from sneaking back in easier.

Let's see if I get an intern in 2022, maybe I can have them focus on
clang-tidy+kernel.
It would also ensure things are kept clean.

Cheers,
Miguel


-- 
Thanks,
~Nick Desaulniers
Thread (15 messages) 15 messages, 7 authors, last reply 2021-12-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help