Re: [PATCH] media: uvcvideo: use dynamic allocation for uvc_copy_op

Hi Kyeongdon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.14 next-20210902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kyeongdon-Kim/media-uvcvideo-use-dynamic-allocation-for-uvc_copy_op/20210902-172043
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-a014-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c9948e9254fbb6ea00f66c7b4542311d21e060be)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2a36e010c8f73cd5c36072caf7e63431a07f4aad
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kyeongdon-Kim/media-uvcvideo-use-dynamic-allocation-for-uvc_copy_op/20210902-172043
        git checkout 2a36e010c8f73cd5c36072caf7e63431a07f4aad
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

drivers/media/usb/uvc/uvc_video.c:1619:19: error: use of undeclared identifier 'uvc_urb'

           for_each_uvc_urb(uvc_urb, stream) {
                            ^

quoted

drivers/media/usb/uvc/uvc_video.c:1619:19: error: use of undeclared identifier 'uvc_urb'
drivers/media/usb/uvc/uvc_video.c:1619:19: error: use of undeclared identifier 'uvc_urb'

   drivers/media/usb/uvc/uvc_video.c:1620:7: error: use of undeclared identifier 'uvc_urb'
                   if (uvc_urb->copy_operations) {
                       ^
   drivers/media/usb/uvc/uvc_video.c:1621:10: error: use of undeclared identifier 'uvc_urb'
                           kfree(uvc_urb->copy_operations);
                                 ^

quoted

drivers/media/usb/uvc/uvc_video.c:1622:4: error: must use 'struct' tag to refer to type 'uvc_urb'

                           uvc_urb->copy_operations = NULL;
                           ^
                           struct 

quoted

drivers/media/usb/uvc/uvc_video.c:1622:11: error: expected identifier or '('

                           uvc_urb->copy_operations = NULL;
                                  ^
   drivers/media/usb/uvc/uvc_video.c:1631:19: error: use of undeclared identifier 'uvc_urb'
           for_each_uvc_urb(uvc_urb, stream) {
                            ^
   drivers/media/usb/uvc/uvc_video.c:1631:19: error: use of undeclared identifier 'uvc_urb'
   drivers/media/usb/uvc/uvc_video.c:1631:19: error: use of undeclared identifier 'uvc_urb'
   drivers/media/usb/uvc/uvc_video.c:1632:3: error: must use 'struct' tag to refer to type 'uvc_urb'
                   uvc_urb->copy_operations
                   ^
                   struct 
   drivers/media/usb/uvc/uvc_video.c:1632:10: error: expected identifier or '('
                   uvc_urb->copy_operations
                          ^
   drivers/media/usb/uvc/uvc_video.c:1634:7: error: use of undeclared identifier 'uvc_urb'
                   if (uvc_urb->copy_operations == NULL)
                       ^
   13 errors generated.


vim +/uvc_urb +1619 drivers/media/usb/uvc/uvc_video.c

  1616	
  1617	static void uvc_free_urb_cop(struct uvc_streaming *stream)
  1618	{

1619		for_each_uvc_urb(uvc_urb, stream) {

  1620			if (uvc_urb->copy_operations) {
  1621				kfree(uvc_urb->copy_operations);

1622				uvc_urb->copy_operations = NULL;

  1623			}
  1624		}
  1625	}
  1626	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org