Re: [PATCH 6/7] fs/ntfs3: Change right headers to lznt.c

Hi Kari,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210831]
[cannot apply to linus/master v5.14 v5.14-rc7 v5.14-rc6 v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kari-Argillander/fs-ntfs3-Refactor-header-includes/20210831-221738
base:    52c7b727581fe725f8b8a283af21fe0651c73c48
config: arm64-buildonly-randconfig-r003-20210901 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/bb35516d85de116979ad1bbcb7a74b3a9b4eda6c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kari-Argillander/fs-ntfs3-Refactor-header-includes/20210831-221738
        git checkout bb35516d85de116979ad1bbcb7a74b3a9b4eda6c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All error/warnings (new ones prefixed by >>):

   In file included from fs/ntfs3/lznt.c:14:

quoted

fs/ntfs3/debug.h:21:31: warning: declaration of 'struct super_block' will not be visible outside of this function [-Wvisibility]

   void ntfs_printk(const struct super_block *sb, const char *fmt, ...);
                                 ^
   In file included from fs/ntfs3/lznt.c:15:

quoted

fs/ntfs3/ntfs_fs.h:1004:11: error: incompatible pointer types passing 'struct super_block *' to parameter of type 'const struct super_block *' [-Werror,-Wincompatible-pointer-types]

           ntfs_err(sb, "failed to read volume at offset 0x%llx",
                    ^~
   fs/ntfs3/debug.h:40:45: note: expanded from macro 'ntfs_err'
   #define ntfs_err(sb, fmt, ...)  ntfs_printk(sb, KERN_ERR fmt, ##__VA_ARGS__)
                                               ^~
   fs/ntfs3/debug.h:21:44: note: passing argument to parameter 'sb' here
   void ntfs_printk(const struct super_block *sb, const char *fmt, ...);
                                              ^
   1 warning and 1 error generated.


vim +1004 fs/ntfs3/ntfs_fs.h

4534a70b7056fd Konstantin Komarov 2021-08-13   995  
4534a70b7056fd Konstantin Komarov 2021-08-13   996  static inline struct buffer_head *ntfs_bread(struct super_block *sb,
4534a70b7056fd Konstantin Komarov 2021-08-13   997  					     sector_t block)
4534a70b7056fd Konstantin Komarov 2021-08-13   998  {
4534a70b7056fd Konstantin Komarov 2021-08-13   999  	struct buffer_head *bh = sb_bread(sb, block);
4534a70b7056fd Konstantin Komarov 2021-08-13  1000  
4534a70b7056fd Konstantin Komarov 2021-08-13  1001  	if (bh)
4534a70b7056fd Konstantin Komarov 2021-08-13  1002  		return bh;
4534a70b7056fd Konstantin Komarov 2021-08-13  1003  
4534a70b7056fd Konstantin Komarov 2021-08-13 @1004  	ntfs_err(sb, "failed to read volume at offset 0x%llx",
4534a70b7056fd Konstantin Komarov 2021-08-13  1005  		 (u64)block << sb->s_blocksize_bits);
4534a70b7056fd Konstantin Komarov 2021-08-13  1006  	return NULL;
4534a70b7056fd Konstantin Komarov 2021-08-13  1007  }
4534a70b7056fd Konstantin Komarov 2021-08-13  1008  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org