Re: [PATCH v12 05/13] vdpa: Add reset callback in vdpa_config_ops
From: kernel test robot <hidden>
Date: 2021-08-30 22:43:26
Also in:
oe-kbuild-all
Hi Xie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [cannot apply to iommu/next lwn/docs-next linus/master v5.14 next-20210830] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210830-222539 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-a003-20210830 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6e5e4d1644120efbf84d53cdf478d49e59643259 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Xie-Yongji/Introduce-VDUSE-vDPA-Device-in-Userspace/20210830-222539 git checkout 6e5e4d1644120efbf84d53cdf478d49e59643259 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All warnings (new ones prefixed by >>):
quoted
drivers/vdpa/ifcvf/ifcvf_main.c:259:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
ifcvf_free_irq(adapter, vf->nr_vring);
^
drivers/vdpa/ifcvf/ifcvf_main.c:257:2: note: previous statement is here
if (status_old & VIRTIO_CONFIG_S_DRIVER_OK)
^
drivers/vdpa/ifcvf/ifcvf_main.c:260:2: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
}
^quoted
drivers/vdpa/ifcvf/ifcvf_main.c:262:2: warning: declaration specifier missing, defaulting to 'int'
ifcvf_reset_vring(adapter);
^
int
drivers/vdpa/ifcvf/ifcvf_main.c:262:20: error: a parameter list without types is only allowed in a function definition
ifcvf_reset_vring(adapter);
^
drivers/vdpa/ifcvf/ifcvf_main.c:264:2: error: expected identifier or '('
return 0;
^
drivers/vdpa/ifcvf/ifcvf_main.c:265:1: error: extraneous closing brace ('}')
}
^quoted
drivers/vdpa/ifcvf/ifcvf_main.c:617:39: warning: shift count >= width of type [-Wshift-count-overflow]
ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
3 warnings and 4 errors generated.
vim +/if +259 drivers/vdpa/ifcvf/ifcvf_main.c
243
244 static int ifcvf_vdpa_reset(struct vdpa_device *vdpa_dev)
245 {
246 struct ifcvf_adapter *adapter;
247 struct ifcvf_hw *vf;
248 u8 status_old;
249
250 vf = vdpa_to_vf(vdpa_dev);
251 adapter = vdpa_to_adapter(vdpa_dev);
252 status_old = ifcvf_get_status(vf);
253
254 if (status_old == 0)
255 return 0;
256
257 if (status_old & VIRTIO_CONFIG_S_DRIVER_OK)
258 ifcvf_stop_datapath(adapter);
> 259 ifcvf_free_irq(adapter, vf->nr_vring);
260 }
261
> 262 ifcvf_reset_vring(adapter);
263
264 return 0;
265 }
266
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 42966 bytes