Re: [PATCH v3 12/14] treewide: replace PagePrivate() with page_private()

On Wed Sep 9, 2026 at 10:23 AM EDT, David Hildenbrand (Arm) wrote:

On 9/9/26 16:18, David Hildenbrand (Arm) wrote:

quoted

On 9/8/26 04:56, Zi Yan wrote:

quoted

PG_private is going to be removed and its check is replaced by checking
page->private != NULL.

You should likely clarify here that, for these users (the pages they deal with),
PG_private is set if and only if page->private != NULL. Consequently, there is
no functional change.

Ah, in previous patch:

+static __always_inline int PagePrivate(const struct page *page)
+{
+	return !!page->private;
+}

So this is not about PG_private *at all* :) Best to clarify that.

Will do the patch split like you suggested and clarify this code change
in the commit message.

-- 
Best Regards,
Yan, Zi