Re: [PATCH v2 3/9] input: dt-bindings: ti,twl4030-keypad: convert to DT schema
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2025-08-14 18:35:57
Also in:
linux-devicetree, linux-input, linux-pwm, linux-sound, linux-usb
On Thu, Aug 14, 2025 at 03:21:23PM +0200, Jihed Chaibi wrote:
quoted hunk ↗ jump to hunk
Convert the legacy TXT binding for the TWL4030 keypad module to the modern YAML DT schema format. This adds formal validation and improves documentation by inheriting from the matrix-keymap schema. Changes in v2: Simplified the description field by removing redundant '|' as it does not affect formatting in this context. Signed-off-by: Jihed Chaibi <redacted> --- .../bindings/input/ti,twl4030-keypad.yaml | 44 +++++++++++++++++++ .../bindings/input/twl4030-keypad.txt | 27 ------------ 2 files changed, 44 insertions(+), 27 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml delete mode 100644 Documentation/devicetree/bindings/input/twl4030-keypad.txtdiff --git a/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml b/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml new file mode 100644 index 000000000..2efc88b89 --- /dev/null +++ b/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml@@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/ti,twl4030-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments TWL4030-family Keypad Controller + +maintainers: + - Peter Ujfalusi <peter.ujfalusi@gmail.com> + +description: + TWL4030's Keypad controller is used to interface a SoC with a matrix-type + keypad device. The keypad controller supports multiple row and column lines. + A key can be placed at each intersection of a unique row and a unique column. + The keypad controller can sense a key-press and key-release and report the + event using a interrupt to the cpu. + +allOf: + - $ref: matrix-keymap.yaml# + +properties: + compatible: + const: ti,twl4030-keypad + + interrupts: + maxItems: 1 + +required: + - compatible + - interrupts + - keypad,num-rows + - keypad,num-columns
I wonder if "linux,keymap" should not be made required as well... Thanks. -- Dmitry