On Tue, 30 Nov 2021 17:34:54 +0100 Alexander Lobakin wrote:

quoted

Another thought on this patch: with individual attributes you could save
some overhead by not sending 0 counters to userspace. e.g., define a
helper that does:  

I know about ETHTOOL_STAT_NOT_SET, but RTNL xstats doesn't use this,
does it?

Not sure if you're asking me or Dave but no, to my knowledge RTNL does
not use such semantics today. But the reason is mostly because there
weren't many driver stats added there. Knowing if an error counter is
not supported or supporter and 0 is important for monitoring. Even if
XDP stats don't have a counter which may not be supported today it's
not a good precedent to make IMO.