Thread (56 messages) 56 messages, 9 authors, 2021-10-17

Re: [PATCH v10 10/11] x86/tdx: Don't write CSTAR MSR on Intel

From: Andi Kleen <hidden>
Date: 2021-10-14 13:47:18

quoted
-	wrmsrl(MSR_CSTAR, (unsigned long)entry_SYSCALL_compat);
+	/*
+	 * CSTAR is not needed on Intel because it doesn't support
+	 * 32bit SYSCALL, but only SYSENTER. On a TDX guest
+	 * it leads to a #GP.
Sigh. Above you write it raises #VE, but now it's #GP !?!

The unhandled #VE trap is handled like a #GP, which is then caught by 
the kernel wrmsr code.

So both are correct.
         Intel CPUs do not support 32-bit SYSCALL. Writing to MSR_CSTAR
         is normaly ignored by the CPU, but raises a #VE trap in a TDX
         guest.

Hmm?
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help