Re: [PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: 2021-09-17 15:26:42
Also in:
linuxppc-dev
On Sat, 11 Sept 2021 at 03:19, Ricardo Neri [off-list ref] wrote:
sched_asmy_prefer() always returns false when called on the local group. By checking local_group, we can avoid additional checks and invoking sched_asmy_prefer() when it is not needed. No functional changes are introduced. Cc: Aubrey Li <redacted> Cc: Ben Segall <bsegall@google.com> Cc: Daniel Bristot de Oliveira <redacted> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Quentin Perret <redacted> Cc: Rafael J. Wysocki <redacted> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tim Chen <redacted> Reviewed-by: Joel Fernandes (Google) <redacted> Reviewed-by: Len Brown <redacted> Signed-off-by: Ricardo Neri <redacted>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
quoted hunk ↗ jump to hunk
--- Changes since v4: * None Changes since v3: * Further rewording of the commit message. (Len) Changes since v2: * Reworded the commit message for clarity. (Peter Z) Changes since v1: * None --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ff69f245b939..7a054f528bcc 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c@@ -8657,7 +8657,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, } /* Check if dst CPU is idle and preferred to this group */ - if (env->sd->flags & SD_ASYM_PACKING && + if (!local_group && env->sd->flags & SD_ASYM_PACKING && env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running && sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) { --2.17.1