On Thursday 19 August 2021 13:23:42 Kari Argillander wrote:

On Thu, Aug 19, 2021 at 10:12:22AM +0200, Pali Rohár wrote:

quoted

On Thursday 19 August 2021 04:21:08 Kari Argillander wrote:

quoted

On Sun, Aug 08, 2021 at 06:24:38PM +0200, Pali Rohár wrote:

quoted

Other fs drivers are using iocharset= mount option for specifying charset.
So mark iocharset= mount option as preferred and deprecate nls= mount
option.

 
One idea is also make this change to fs/fc_parser.c and then when we
want we can drop support from all filesystem same time. This way we
can get more deprecated code off the fs drivers. Draw back is that
then every filesstem has this deprecated nls= option if it support
iocharsets option. But that should imo be ok.

Beware that iocharset= is required only for fs which store filenames in
some specific encoding (in this case extension to UTF-16). For fs which
store filenames in raw bytes this option should not be parsed at all.

Yeah of course. I was thinking that what we do is that if key is nls=
we change key to iocharset, print deprecated and then send it to driver
parser as usual. This way driver parser will never know that user
specifie nls= because it just get iocharset. But this is probebly too
fancy way to think simple problem. Just idea. 

This has an issue that when you use nls= option for e.g. ext4 fs then
kernel starts reporting that nls= for ext4 is deprecated. But there is
no nls= option and neither iocharset= option for ext4. So kernel should
not start reporting such warnings for ext4.

quoted

Therefore I'm not sure if this parsing should be in global
fs/fc_parser.c file...