Re: [PATCH v14 019/138] mm/filemap: Add folio_lock_killable()
From: David Howells <dhowells@redhat.com>
Date: 2021-08-10 15:33:13
Also in:
linux-fsdevel, linux-mm
From: David Howells <dhowells@redhat.com>
Date: 2021-08-10 15:33:13
Also in:
linux-fsdevel, linux-mm
Matthew Wilcox (Oracle) [off-list ref] wrote:
This is like lock_page_killable() but for use by callers who know they have a folio. Convert __lock_page_killable() to be __folio_lock_killable(). This saves one call to compound_head() per contended call to lock_page_killable(). __folio_lock_killable() is 19 bytes smaller than __lock_page_killable() was. filemap_fault() shrinks by 74 bytes and __lock_page_or_retry() shrinks by 71 bytes. That's a total of 164 bytes of text saved. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Jeff Layton <jlayton@kernel.org> Acked-by: Kirill A. Shutemov <redacted> Acked-by: Vlastimil Babka <redacted> Reviewed-by: William Kucharski <redacted>
Reviewed-by: David Howells <dhowells@redhat.com>