[PATCH v1] driver core: fw_devlink: Don't create device links for devices not on a bus
STALE1856d
From: Saravana Kannan <hidden>
Date: 2021-08-31 22:45:20
Subsystem:
driver core, kobjects, debugfs and sysfs, the rest · Maintainers:
Greg Kroah-Hartman, "Rafael J. Wysocki", Danilo Krummrich, Linus Torvalds
Devices that are not on a bus will never have a driver bound to it. So, fw_devlink should not create device links for it as it can cause probe issues[1] or sync_state() call back issues[2]. [1] - https://lore.kernel.org/lkml/CAGETcx_xJCqOWtwZ9Ee2+0sPGNLM5=F=djtbdYENkAYZa0ynqQ@mail.gmail.com/ (local) [2] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/ (local) Fixes: f9aa460672c9 ("driver core: Refactor fw_devlink feature") Reported-by: Ulf Hansson <redacted> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Saravana Kannan <redacted> --- drivers/base/core.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index f6360490a4a3..304a06314656 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c@@ -1719,8 +1719,24 @@ static int fw_devlink_create_devlink(struct device *con, struct device *sup_dev; int ret = 0; + /* + * If a consumer device is not on a bus (i.e. a driver will never bind + * to it), it doesn't make sense for fw_devlink to create device links + * for it. + */ + if (con->bus == NULL) + return -EINVAL; + sup_dev = get_dev_from_fwnode(sup_handle); if (sup_dev) { + /* + * If a supplier device is not on a bus (i.e. a driver will + * never bind to it), it doesn't make sense for fw_devlink to + * create device links for it. + */ + if (sup_dev->bus == NULL) + return -EINVAL; + /* * If it's one of those drivers that don't actually bind to * their device using driver core, then don't wait on this
--
2.33.0.259.gc128427fd7-goog