On Fri, 13 Aug 2021 at 03:40, Tao Ren [off-list ref] wrote:

On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote:

quoted

On Thu, 5 Aug 2021 at 22:28, [off-list ref] wrote:

quoted

+&mdio1 {
+       status = "okay";

You're enabling this but it looks like it's unused?

Thanks Joel for the careful review. The MDIO controller is not paired
with BMC MAC; instead, it's connected to the MDC/MDIO interface of the
on-board switch (whose ports are connected to BMC, Host and front panel
management port).

I see!

In other word, the MDIO controller is used, but we do need some user
space scripts to control the controller. What's your suggestion? For
example, should I add some comments to explain the purpose?

Yes, that would make sense.

I've applied your patch, so if you want to add comments please send a
diff against this tree:

https://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git/log/?h=dt-for-v5.15