Thread (13 messages) 13 messages, 2 authors, 2021-08-02

Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param

From: jim.cromie@gmail.com
Date: 2021-08-02 18:37:12
Also in: amd-gfx, dri-devel, intel-gfx

On Mon, Aug 2, 2021 at 10:18 AM Emil Velikov [off-list ref] wrote:
Hi Jim,

On Sat, 31 Jul 2021 at 22:42, Jim Cromie [off-list ref] wrote:
quoted
Use of this new data member will be rare, it might be worth redoing
this as a separate/sub-type to keep the base case.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/linux/moduleparam.h | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
index eed280fae433..e9495b1e794d 100644
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -78,6 +78,7 @@ struct kernel_param {
                const struct kparam_string *str;
                const struct kparam_array *arr;
        };
+       void *data;
Might as well make this "const void *" since it is a compile-time constant?
yes indeed. revising.  thanks
-Emil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help