Thread (49 messages) 49 messages, 8 authors, 2021-07-12

Re: [RFC PATCH V3 11/11] HV/Storvsc: Add Isolation VM support for storvsc driver

From: Tianyu Lan <hidden>
Date: 2021-06-07 15:01:03
Also in: linux-arch, linux-hyperv, linux-iommu, linux-scsi, netdev, xen-devel


On 6/7/2021 2:46 PM, Christoph Hellwig wrote:
On Sun, May 30, 2021 at 11:06:28AM -0400, Tianyu Lan wrote:
quoted
+				for (i = 0; i < request->hvpg_count; i++)
+					dma_unmap_page(&device->device,
+							request->dma_range[i].dma,
+							request->dma_range[i].mapping_size,
+							request->vstor_packet.vm_srb.data_in
+							     == READ_TYPE ?
+							DMA_FROM_DEVICE : DMA_TO_DEVICE);
+				kfree(request->dma_range);
Unreadably long lines.  You probably want to factor the quoted code into
a little readable helper and do the same for the map side.
Good suggestion. Will update.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help