Thread (8 messages) 8 messages, 3 authors, 2021-06-01

Re: [PATCH] sched/debug:fix stale comments of sched_debug

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-06-01 07:57:45

On Mon, May 31, 2021 at 07:05:22PM +0300, Andy Shevchenko wrote:
quoted
quoted
quoted
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1166,7 +1166,7 @@ config SCHED_DEBUG
 	depends on DEBUG_KERNEL && PROC_FS
Are the dependencies correct?
Based on your suggestion, I checked and it turned out that PROC_FS is not
the correct dependency, but DEBUG_FS. 
I guess you missed something.
quoted
Shoud I change it to DEBUG_FS?
Please, double check.
Thing is that proc_sched_show_task() still wants PROC_FS, i've not yet
found a suitable debugfs based location for that.

And DEBUG_FS doesn't need a dependency; it has complete DEBUG_FS=n
wrappers and will build fine. Arguably selecting SCHED_DEBUG without
DEBUG_FS is daft, but it should work.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help