Thread (3 messages) 3 messages, 2 authors, 2021-03-18

Re: Checkpatch still worries about include/asm/ ?

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: 2021-03-18 17:04:07
Also in: linux-kernel-mentees

On Thu, Mar 18, 2021 at 5:47 PM Dwaipayan Ray [off-list ref] wrote:
Hello,
include/asm/ got removed a long time back (probably v1.1.45).
Checkpatch still worries about that:

if ($realfile =~ m@^include/asm/@) {
ERROR("MODIFIED_INCLUDE_ASM",
"do not modify files in include/asm, change architecture specific
files in include/asm-<architecture>\n" . "$here$rawline\n");
}

Can we remove this check?
Wow, v1.1.45... that must have been taking quite some digging in the
ancient dirt to find that out.

I agree, let us remove that rule.

Thanks for the documentation effort on checkpatch.pl and cleaning up
obsolete rules while documenting.

Lukas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help