Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

[PATCH v2 0/4] add device drivers for Siemens Industrial PCs · Henning Schild <hidden> · 2021-03-15
[PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs · Hans de Goede <hidden> · 2021-03-15
Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs · Henning Schild <hidden> · 2021-03-15
[PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Henning Schild <hidden> · 2021-03-15
Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Hans de Goede <hidden> · 2021-03-15
Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Henning Schild <hidden> · 2021-03-15
Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Hans de Goede <hidden> · 2021-03-15
Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Henning Schild <hidden> · 2021-03-16
Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries · Hans de Goede <hidden> · 2021-03-16
Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs · kernel test robot <hidden> · 2021-03-15
[PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs · Guenter Roeck <linux@roeck-us.net> · 2021-03-15
Re: [PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs · Henning Schild <hidden> · 2021-03-29
[PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Andy Shevchenko <hidden> · 2021-03-15
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Pavel Machek <hidden> · 2021-03-15
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Andy Shevchenko <hidden> · 2021-03-15
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Enrico Weigelt, metux IT consult <hidden> · 2021-03-18
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-27
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Enrico Weigelt, metux IT consult <hidden> · 2021-04-01
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-27
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Enrico Weigelt, metux IT consult <hidden> · 2021-03-18
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Alexander Dahl <hidden> · 2021-03-18
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-23
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-26
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Enrico Weigelt, metux IT consult <hidden> · 2021-03-18
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-27
Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs · Henning Schild <hidden> · 2021-03-27
[PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Andy Shevchenko <hidden> · 2021-03-15
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Henning Schild <hidden> · 2021-03-17
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Hans de Goede <hidden> · 2021-03-17
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Enrico Weigelt, metux IT consult <hidden> · 2021-03-18
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Hans de Goede <hidden> · 2021-03-18
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Henning Schild <hidden> · 2021-03-26
Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices · Hans de Goede <hidden> · 2021-03-26
Re: [PATCH v2 0/4] add device drivers for Siemens Industrial PCs · Andy Shevchenko <hidden> · 2021-03-15
Re: [PATCH v2 0/4] add device drivers for Siemens Industrial PCs · Henning Schild <hidden> · 2021-03-15
Re: [PATCH v2 0/4] add device drivers for Siemens Industrial PCs · Henning Schild <hidden> · 2021-08-02

From: Andy Shevchenko <hidden>
Date: 2021-03-15 11:27:44
Also in: linux-leds, linux-watchdog, platform-driver-x86

On Mon, Mar 15, 2021 at 1:19 PM Pavel Machek [off-list ref] wrote:

quoted

+       struct simatic_ipc_led *led =
+               container_of(led_cd, struct simatic_ipc_led, cdev);

One line?

80 columns. It is fine as it is.

With the inline helper it will be possible to have this neat and short.

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help