Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count()
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2017-03-14 11:53:50
Also in:
linux-gpio, linux-input, platform-driver-x86
On Tue, Mar 14, 2017 at 10:43:02AM +0100, Linus Walleij wrote:
On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko [off-list ref] wrote:quoted
It's unusual to have error checking like (ret <= 0) in cases when counting GPIO resources. In case when it's mandatory we propagate the error (-ENOENT), otherwise we don't use the result. This makes consistent behaviour across all possible variants called in gpiod_count(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>Mika/Rafael, can you look at this patch?
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>