On Wed, 2016-08-31 at 12:34 -0700, Junio C Hamano wrote:

Joe Perches [off-list ref] writes:

quoted

Many commits have various forms of bylines similar to

A missing blank line (I can tweak while queuing).

[]

quoted

+				next if $suppress_cc{'bylines'} and $what !~ /Signed-off-by/i and $what =~ /by$/i;

Having to keep this /by$/i in sync with whatever definition of
bylines is will be error prone.  How about doing it in this way?

	# Now parse the message body
+	my $bypat = r/[\w-]+-by/;
	while (<$fh>) {
        	...
                if (/^(Signed-off-by|Cc|$bypat): (.*)$/i) {
                	...
                        	next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;
+				next if $suppress_cc{'bylines'} and
+					$what !~ /^Signed-off-by/i and
+					$what =~ /^$bypat/i;

Other than that, looking good.

Sure, whatever you want, do you want a v3 from me or can
you fix it up however you want?