Hi Rob,
-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: 2016年7月30日 5:40
To: Wenyou Yang <redacted>
Cc: Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov
[off-list ref]; David Woodhouse [off-list ref]; Pawel
Moll [off-list ref]; Mark Brown [off-list ref]; Ian Campbell
[off-list ref]; Kumar Gala [off-list ref]; linux-
kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; Nicolas Ferre [off-list ref]; linux-
pm@vger.kernel.org
Subject: Re: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties
On Fri, Jul 29, 2016 at 09:25:28AM +0800, Wenyou Yang wrote:
quoted
Due the driver improvements, update the properties,
- Remove "active-semi,check-battery-temperature" property.
- Add the properties, "active-semi,irq_gpio"
and "active-semi,lbo-gpios".
Signed-off-by: Wenyou Yang <redacted>
---
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt
b/Documentation/devicetree/bindings/power/act8945a-charger.txt
quoted
index bea254c..d7cf05b 100644
--- a/Documentation/devicetree/bindings/power/act8945a-charger.txt
+++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt
@@ -4,10 +4,12 @@ Required properties:
- compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt.
- active-semi,chglev-gpios: charge current level phandle with args
as described in ../gpio/gpio.txt.
+ - active-semi,irq_gpios: specify the charger interrupt input phanle
+ with args as as described in ../gpio/gpio.txt.
As I said in v2, this should be an interrupt property instead.
Sorry for forgetting to change.
Accepted, will be in next version. Thanks.
quoted
+ - active-semi,lbo-gpios: specify the low battery voltage detect phandle
+ with args as as described in ../gpio/gpio.txt.
Maybe this one too.
The capacity level function need to read this pin level, so this one should not
use "interrupts" property.
quoted
Optional properties:
- - active-semi,check-battery-temperature: boolean to check the battery
- temperature or not.
- active-semi,input-voltage-threshold-microvolt: unit: mV;
Specifies the charger's input over-voltage threshold value;
The value can be: 6600, 7000, 7500, 8000; default: 6600
--
2.7.4
Best Regards,
Wenyou Yang